Open
Conversation
| .filter(a -> foundVarNames.contains(a.first())) | ||
| // only include variables that appear in the found value and are not already fixed there | ||
| .filter(a -> foundVarNames.contains(a.first()) | ||
| && !foundAssignments.contains(a.first() + " == " + a.second())) |
Collaborator
There was a problem hiding this comment.
What if a.second() is another variable? Or are we already sure that we are in a simplified version where thats not possible
Collaborator
Author
There was a problem hiding this comment.
I'm not sure, but I'm guessing that Z3 always returns the most simplified form, meaning the RHS would be a value and not another variable. If that's not the case for some weird example, the worst thing that can happen is showing an extra assignment in the counterexample (which is better than incorrectly hiding it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves counterexample filtering by only keeping assignments for variables that appear in the found expression and whose exact assignments are not already present there. This avoids relying on a full string comparison between the counterexample and the found expression, which could fail when the same assignments appeared in a different order.
Example
Before
After